feat: add lz4 to SnapshotSegment::Headers
#6487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Feb 8, 2024
|
|
||
| // Transaction and Receipt already have the compression scheme used natively in its encoding. | ||
| // (zstd-dictionary) | ||
| if matches!(segment, SnapshotSegment::Headers) { |
There was a problem hiding this comment.
nit: can add fn is_ for segment separately
shekhirin
approved these changes
Feb 8, 2024
shekhirin
force-pushed
the
feat/static-files
branch
5 times, most recently
from
dd6aa63
to
613f319
Compare
gakonst
approved these changes
Feb 8, 2024
|
Run this a couple times on both branches (with a cherry picked from #6608) and didn't see a difference so merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds compression to Header static file segments.
Holesky near tip
Before: 510MB
After: 352MB
On previous tests done before, there wasn't a noticeable impact on read performance, but will use flood to confirm it. So pending merge
Not adding for other segments, since they already leverage the codec compression (global zstd dictionary)